Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing type declarations + exclude tests from dist #10

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

jeanregisser
Copy link
Member

@jeanregisser jeanregisser commented Apr 19, 2024

Trying to consume the lib I noticed TS was complaining about the missing types.
Also it was including extra things from tests.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.33%. Comparing base (0a23b3a) to head (270c603).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files           2        2           
  Lines          60       60           
  Branches        6        6           
=======================================
  Hits           56       56           
  Misses          4        4           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a23b3a...270c603. Read the comment docs.

@jeanregisser jeanregisser enabled auto-merge (squash) April 19, 2024 12:33
@jeanregisser jeanregisser merged commit 841f486 into main Apr 19, 2024
7 checks passed
@jeanregisser jeanregisser deleted the jeanregisser/fix-missing-types branch April 19, 2024 12:35
Copy link

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants