chore(cleanup): Remove show_onboarding_phone_verification feature gate (

#6304)

### Description

Title

### Test plan

CI

### Related issues

- Part of ACT-1443

### Backwards compatibility

Yes
### Network scalability

If a new NetworkId and/or Network are added in the future, the changes
in this PR will:

- N/A

src/keylessBackup/SignInWithEmail.test.tsx

@@ -1,8 +1,8 @@
 import { fireEvent, render, waitFor } from '@testing-library/react-native'
 import React from 'react'
 import { Provider } from 'react-redux'
-import { KeylessBackupEvents } from 'src/analytics/Events'
 import AppAnalytics from 'src/analytics/AppAnalytics'
+import { KeylessBackupEvents } from 'src/analytics/Events'
 import SignInWithEmail from 'src/keylessBackup/SignInWithEmail'
 import { auth0SignInCompleted } from 'src/keylessBackup/slice'
 import { KeylessBackupFlow, KeylessBackupOrigin } from 'src/keylessBackup/types'
@@ -59,11 +59,7 @@ describe('SignInWithEmail', () => {
     mockGetCredentials.mockResolvedValue({ idToken: 'mock-token' })
     jest
       .mocked(getFeatureGate)
-      .mockImplementation(
-        (gate) =>
-          gate === StatsigFeatureGates.SHOW_APPLE_IN_CAB ||
-          gate === StatsigFeatureGates.SHOW_ONBOARDING_PHONE_VERIFICATION
-      )
+      .mockImplementation((gate) => gate === StatsigFeatureGates.SHOW_APPLE_IN_CAB)
     logWarnSpy = jest.spyOn(Logger, 'warn')
     logDebugSpy = jest.spyOn(Logger, 'debug')
   })

src/statsig/index.ts

@@ -117,10 +117,7 @@ export function getFeatureGate(featureGateName: StatsigFeatureGates) {
     Logger.warn(TAG, `Error getting feature gate: ${featureGateName}`, error)
     // gates should always default to false, this boolean is to just remain BC
     // with two gates defaulting to true
-    return (
-      featureGateName === StatsigFeatureGates.ALLOW_HOOKS_PREVIEW ||
-      featureGateName === StatsigFeatureGates.SHOW_ONBOARDING_PHONE_VERIFICATION
-    )
+    return featureGateName === StatsigFeatureGates.ALLOW_HOOKS_PREVIEW
   }
 }
 

src/statsig/types.ts

@@ -34,7 +34,6 @@ export enum StatsigFeatureGates {
   SUBSIDIZE_STABLECOIN_EARN_GAS_FEES = 'subsidize_stablecoin_earn_gas_fees',
   SHOW_CASH_IN_TOKEN_FILTERS = 'show_cash_in_token_filters',
   ALLOW_CROSS_CHAIN_SWAPS = 'allow_cross_chain_swaps',
-  SHOW_ONBOARDING_PHONE_VERIFICATION = 'show_onboarding_phone_verification',
   SHOW_APPLE_IN_CAB = 'show_apple_in_cab',
   SHOW_SWAP_AND_DEPOSIT = 'show_swap_and_deposit',
   SHOW_UK_COMPLIANT_VARIANT = 'show_uk_compliant_variant',