Update to @testing-library/react-native and add @testing-library/jest-native

[MuckT]

Description

Migration from react-native-testing-library to @testing-library/react-native: Migration Guide V2 & Migration Guide V7. @testing-library/jest-native was also added to cover asserts on disabled elements to replace checks on props that failed with the update to @testing-library/react-native.

Other changes

• Mobile test batching introduced in Batch Mobile Tests #1021 has been removed as the underlying issue is resolved.

• flushMicroTasksQueue is now a helper function in /tests/utils as it has been deprecated by @testing-library/react-native.

• Cleanup in packages/mobile/jest_setup.ts has been removed as it is built in to @testing-library/react-native.

• Deprecated methods that were used in tests have been marked with UNSAFE_ read more about it here.

• waitForElement is now waitFor - WaitFor API Changes.

• Use @testing-library/react-native render method instead of react-test-renderer render method.

Tested

• Tests run Locally and in CI.

How others should test

• Run the all tests locally with yarn test
• Run a specific test locally with yarn test <target.test.tsx>

Related issues

• Fixes Implement @testing-library/react-native for Mobile & Component Tests #1093, Fix segfault exception that happens on the Mobile test check #1040 🤞

Backwards compatibility

This change is not backwards compatible, but all existing tests have been updated to use @testing-library/react-native and @testing-library/jest-native.

[codecov]

Codecov Report

Merging #1184 (2b11124) into main (88f613d) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
+ Coverage   74.77%   75.02%   +0.25%     
==========================================
  Files         525      526       +1     
  Lines       18404    18410       +6     
  Branches     3282     3282              
==========================================
+ Hits        13762    13813      +51     
+ Misses       4595     4536      -59     
- Partials       47       61      +14     

Impacted Files	Coverage Δ
packages/mobile/src/components/Dialog.tsx	94.44% <ø> (ø)
packages/mobile/src/components/Modal.tsx	100.00% <100.00%> (ø)
packages/mobile/test/utils.ts	75.00% <100.00%> (+0.92%)	⬆️
packages/react-components/test/utils.ts	100.00% <100.00%> (ø)
packages/mobile/src/config.ts	94.20% <0.00%> (ø)
packages/mobile/src/utils/Logger.ts	58.33% <0.00%> (ø)
packages/mobile/src/verify/hooks.ts	42.85% <0.00%> (ø)
packages/mobile/src/pincode/authentication.ts	48.55% <0.00%> (ø)
packages/mobile/src/account/FiatExchange.tsx	70.00% <0.00%> (+1.66%)	⬆️
... and 14 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88f613d...2b11124. Read the comment docs.

[jeanregisser]

Amazing!! Thanks 🚀

Let's try to fix the skipped tests before merging.
Do you see what's needed to add them back?

[jeanregisser]

Why is @ts-ignore needed here?

[MuckT]

If I remove the // @ts-ignore I receive the warning the following warning in the IDE; however the tests run without issue.
Module '"@testing-library/jest-native"' has no exported member 'toBeDisabled'.ts(2305)

[MuckT]

@jeanregisser @lisaqyli tests have been skipped in the following specs due to issues with the upgrade to @testing-library/react-native and should be fixed prior to merging.

• Fix skipped tests in SupportContact.test.tsx
• Fix skipped tests in WithdrawCeloQrScannerScreen.test.tsx
• Fix skipped tests in SendConfirmation.test.tsx
• Fix skipped tests in SettingsItem.test.tsx
• Fix skipped tests in TotalLineItem.test.tsx
• Fix skipped tests in DrawerNavigator.test.tsx

[jeanregisser]

Great, do you want some help to get make the skipped test pass?

[MuckT]

@jeanregisser any of the tests remaining in the above comment I could use help fixing.

[jeanregisser]

🥳