-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reduce logs for redux logger, analytics, remote config #6103
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6103 +/- ##
==========================================
- Coverage 88.74% 88.74% -0.01%
==========================================
Files 727 727
Lines 30784 30791 +7
Branches 5624 5626 +2
==========================================
+ Hits 27320 27325 +5
- Misses 3265 3267 +2
Partials 199 199
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm supportive of these changes -- definitely think there's a lot of noise in the logs atm from some of the API calls we make, though curious what others think of this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 🚀
Co-authored-by: Jean Regisser <jean.regisser@gmail.com>
Description
This PR tries to reduce the amount of noise in the logs, to make it easier to parse user logs and debug issues.
I think we should
Test plan
n/a
Related issues
n/a
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: