Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce logs for redux logger, analytics, remote config #6103

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

kathaypacific
Copy link
Collaborator

Description

This PR tries to reduce the amount of noise in the logs, to make it easier to parse user logs and debug issues.

I think we should

  • exclude logging of service responses (e.g. in remote config, redux action payloads which store responses in redux)
  • stop logging analytics properties, since we can get that information from our analytics tools (the properties are helpful during dev though)

Test plan

n/a

Related issues

n/a

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.74%. Comparing base (36b4546) to head (b68827b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/analytics/AppAnalytics.ts 75.00% 1 Missing ⚠️
src/redux/sagas.ts 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6103      +/-   ##
==========================================
- Coverage   88.74%   88.74%   -0.01%     
==========================================
  Files         727      727              
  Lines       30784    30791       +7     
  Branches     5624     5626       +2     
==========================================
+ Hits        27320    27325       +5     
- Misses       3265     3267       +2     
  Partials      199      199              
Files with missing lines Coverage Δ
src/firebase/firebase.ts 41.45% <ø> (+0.21%) ⬆️
src/analytics/AppAnalytics.ts 67.92% <75.00%> (-0.03%) ⬇️
src/redux/sagas.ts 49.00% <87.50%> (+2.68%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b4546...b68827b. Read the comment docs.

Copy link
Contributor

@jophish jophish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm supportive of these changes -- definitely think there's a lot of noise in the logs atm from some of the API calls we make, though curious what others think of this!

Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀

src/redux/sagas.ts Outdated Show resolved Hide resolved
Co-authored-by: Jean Regisser <jean.regisser@gmail.com>
@kathaypacific kathaypacific added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 341e0f8 Sep 30, 2024
15 checks passed
@kathaypacific kathaypacific deleted the kathy/logs-reduce-noise branch September 30, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants