Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(headers): use empty string for title #6113

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

satish-ravi
Copy link
Contributor

Description

Fixes an iOS 18 only issue where header is shown as " "

Test plan

Tested on multiple versions across iOS and Android w/ @MuckT

Before After

Related issues

  • N/A

Backwards compatibility

yes

Network scalability

N/A

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (312d7e0) to head (5c2e849).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6113   +/-   ##
=======================================
  Coverage   88.74%   88.74%           
=======================================
  Files         727      727           
  Lines       30785    30785           
  Branches     5623     5623           
=======================================
  Hits        27321    27321           
  Misses       3265     3265           
  Partials      199      199           
Files with missing lines Coverage Δ
src/navigator/Headers.tsx 61.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 312d7e0...5c2e849. Read the comment docs.

@satish-ravi satish-ravi added this pull request to the merge queue Sep 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 30, 2024
@satish-ravi satish-ravi added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit cb70b7f Oct 1, 2024
15 checks passed
@satish-ravi satish-ravi deleted the satish/fix-header branch October 1, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants