chore(earn): Beefy terms and conditions changes #6127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnian0826
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6127 +/- ##
=======================================
Coverage 88.75% 88.75%
=======================================
Files 727 727
Lines 30794 30804 +10
Branches 5627 5626 -1
=======================================
+ Hits 27330 27339 +9
- Misses 3265 3266 +1
Partials 199 199
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
MuckT
reviewed
Oct 2, 2024
src/earn/EarnDepositBottomSheet.tsx
Outdated
| i18nKey="earnFlow.depositBottomSheet.noTermsUrlFooter" | ||
| tOptions={{ providerName: pool.appName }} | ||
| > | ||
| <Text |
There was a problem hiding this comment.
Should we conditionally render this if APP_ID_TO_PROVIDER_DOCUMENTS_URL[pool.appId] is undefined? Also What happens to the translation in that case?
There was a problem hiding this comment.
updated in 0cfe241
MuckT
approved these changes
Oct 2, 2024
bakoushin
pushed a commit
that referenced
this pull request
Oct 17, 2024
### Description Allow for showing provider docs and valora T&Cs if provider T&Cs don't exist ### Test plan <img src="https://github.com/user-attachments/assets/78e09a87-1153-4287-bfc5-8471f64a3da0" width="250" /> https://github.com/user-attachments/assets/a3ea05b2-a4f7-49c7-b753-745f62290c27 ### Related issues - Fixes ACT-1399 ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [X] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow for showing provider docs and valora T&Cs if provider T&Cs don't exist
Test plan
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-02.at.11.26.12.mp4
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: