feat(earn): support partial withdrawals #6128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6128 +/- ##
=======================================
Coverage 88.78% 88.79%
=======================================
Files 728 728
Lines 30870 30941 +71
Branches 5645 5669 +24
=======================================
+ Hits 27409 27474 +65
- Misses 3264 3270 +6
Partials 197 197
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
MuckT
commented
Oct 9, 2024
# Conflicts: # src/earn/EarnDepositBottomSheet.tsx
finnian0826
reviewed
Oct 9, 2024
Co-authored-by: Finnian Jacobson-Schulte <140328381+finnian0826@users.noreply.github.com>
jh2oman
requested changes
Oct 10, 2024
jh2oman
reviewed
Oct 10, 2024
jh2oman
reviewed
Oct 11, 2024
jh2oman
reviewed
Oct 11, 2024
satish-ravi
reviewed
Oct 16, 2024
This reverts commit 775a925.
satish-ravi
reviewed
Oct 17, 2024
satish-ravi
reviewed
Oct 17, 2024
| fireEvent.changeText(getByTestId('EarnEnterAmount/TokenAmountInput'), '20.001') | ||
| expect(getByTestId('EarnEnterAmount/NotEnoughBalanceWarning')).toBeTruthy() | ||
| expect(getByTestId('EarnEnterAmount/Continue')).toBeDisabled() | ||
| }) |
There was a problem hiding this comment.
can we add tests for checking transaction preparation is called with the right amounts?
Co-authored-by: Satish Ravi <satish.ravi@valoraapp.com>
satish-ravi
approved these changes
Oct 18, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to support partial withdrawals from Earn pools and adds the feature gate
allow_earn_partial_withdrawalto enable this feature.Test plan
Related issues
Backwards compatibility
Yes
Network scalability
Yes