fix(earn): fix wrapping and alignments on pool info screen #6143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jh2oman
commented
Oct 10, 2024
| size={IconSize.XXSMALL} | ||
| showNetworkIcon={false} | ||
| /> | ||
| <View style={styles.yieldRateLabelContainer}> |
There was a problem hiding this comment.
All of the other contents of a <View style={styles.cardLineLabel}> are a single component, and it makes the styles simpler if this one is too. So, I added a wrapper component
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6143 +/- ##
==========================================
- Coverage 88.75% 88.74% -0.02%
==========================================
Files 721 721
Lines 30586 30586
Branches 5588 5588
==========================================
- Hits 27147 27143 -4
+ Misses 3397 3246 -151
- Partials 42 197 +155
... and 68 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
satish-ravi
approved these changes
Oct 10, 2024
bakoushin
pushed a commit
that referenced
this pull request
Oct 17, 2024
### Description https://linear.app/valora/issue/ACT-1407/earn-pool-info-screen-ui-improvement https://github.com/user-attachments/assets/2dd38a0d-a9b9-4f10-beb0-6d10cc310b0f | Before |After | | --- | --- | | <img src="https://github.com/user-attachments/assets/1084f9f7-83d3-4fff-82cc-5df345e8f19b" width="250px"> | <img src="https://github.com/user-attachments/assets/2dd38a0d-a9b9-4f10-beb0-6d10cc310b0f" width="250px"> | ### Test plan tested manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://linear.app/valora/issue/ACT-1407/earn-pool-info-screen-ui-improvement
https://github.com/user-attachments/assets/2dd38a0d-a9b9-4f10-beb0-6d10cc310b0f
Test plan
tested manually