feat: earn confirmation screen display #6144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/earn/EarnDepositBottomSheet.tsx
Co-authored-by: Finnian Jacobson-Schulte <140328381+finnian0826@users.noreply.github.com>
MuckT
commented
Oct 23, 2024
jh2oman
reviewed
Oct 28, 2024
jh2oman
reviewed
Oct 28, 2024
jh2oman
reviewed
Oct 28, 2024
jh2oman
reviewed
Oct 29, 2024
jh2oman
reviewed
Oct 29, 2024
jophish
pushed a commit
to mobilestack-xyz/mobilestack-runtime
that referenced
this pull request
Nov 12, 2024
### Description Renames the `EarnCollectScreen.tsx` to `EarnConfirmationScreen.tsx` and updates the screen to handle the display partial withdrawals. Submitting the withdrawals will be in a follow-up PR & this screen is not used when the feature gate `ALLOW_EARN_PARTIAL_WITHDRAWAL` is false. ### Screenshots | iOS Enter Amount | iOS Confirmation | | ---- | ---- | |  |  | ### Test plan - [x] Tested locally on iOS - [x] Tested locally on Android - [x] Unit tests updated ### Related issues - Part of ACT-1389 ### Backwards compatibility Yes ### Network scalability N/A --------- Co-authored-by: Finnian Jacobson-Schulte <140328381+finnian0826@users.noreply.github.com> Co-authored-by: Jacob Waterman <jacobrwaterman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames the
EarnCollectScreen.tsxtoEarnConfirmationScreen.tsxand updates the screen to handle the display partial withdrawals. Submitting the withdrawals will be in a follow-up PR & this screen is not used when the feature gateALLOW_EARN_PARTIAL_WITHDRAWALis false.Screenshots
Test plan
Related issues
Backwards compatibility
Yes
Network scalability
N/A