-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(TransactionFeedV2): Add tracking for newly completed cross-chain swaps #6156
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6156 +/- ##
==========================================
- Coverage 88.86% 88.85% -0.01%
==========================================
Files 728 728
Lines 30889 30934 +45
Branches 5650 5676 +26
==========================================
+ Hits 27448 27487 +39
- Misses 3245 3251 +6
Partials 196 196
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
trackCompletionOfCrossChainSwaps(newlyCompletedCrossChainSwaps) | ||
} | ||
}, | ||
[data?.transactions, standByTransactions.pending] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a risk that the tracking could be triggered twice if one of these deps change without being in sync with the other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeanregisser You're right! Initially, I thought is shouldn't be a problem based on how the flow of data?.transactions
and standByTransactions
is tightly connected. But now as I think about it, it makes a lot more sense to utilize and add an extra field to useNewlyCompletedTransactions
as it should be more precise in signaling the change.
@jeanregisser updated |
b6bb048
to
e2cf8ff
Compare
Description
9th PR for RET-1207. Implements tracking for newly completed cross-chain swaps.
Test plan
Re-used existing corresponding test for the same functionality from existing feed.
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: