Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TransactionFeedV2): Add tracking for newly completed cross-chain swaps #6156

Merged
merged 26 commits into from
Oct 18, 2024

Conversation

sviderock
Copy link
Contributor

Description

9th PR for RET-1207. Implements tracking for newly completed cross-chain swaps.

Test plan

Re-used existing corresponding test for the same functionality from existing feed.

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 90.74074% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.85%. Comparing base (89e51c4) to head (0d45274).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/transactions/feed/TransactionFeedV2.tsx 90.74% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6156      +/-   ##
==========================================
- Coverage   88.86%   88.85%   -0.01%     
==========================================
  Files         728      728              
  Lines       30889    30934      +45     
  Branches     5650     5676      +26     
==========================================
+ Hits        27448    27487      +39     
- Misses       3245     3251       +6     
  Partials      196      196              
Files with missing lines Coverage Δ
src/transactions/feed/TransactionFeedV2.tsx 92.47% <90.74%> (+0.21%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e51c4...0d45274. Read the comment docs.

Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

trackCompletionOfCrossChainSwaps(newlyCompletedCrossChainSwaps)
}
},
[data?.transactions, standByTransactions.pending]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a risk that the tracking could be triggered twice if one of these deps change without being in sync with the other?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeanregisser You're right! Initially, I thought is shouldn't be a problem based on how the flow of data?.transactions and standByTransactions is tightly connected. But now as I think about it, it makes a lot more sense to utilize and add an extra field to useNewlyCompletedTransactions as it should be more precise in signaling the change.

@sviderock
Copy link
Contributor Author

@jeanregisser updated

@sviderock sviderock force-pushed the slava/feed-v2-vibrate-on-success branch from b6bb048 to e2cf8ff Compare October 16, 2024 14:12
Base automatically changed from slava/feed-v2-vibrate-on-success to main October 18, 2024 07:07
@sviderock sviderock added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 36cb21d Oct 18, 2024
15 checks passed
@sviderock sviderock deleted the slava/feed-v2-track-cross-chain branch October 18, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants