Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(earn): Show Withdrawing and Claiming card when withdrawalIncludesClaim is true #6168

Merged
merged 61 commits into from
Oct 18, 2024

Conversation

finnian0826
Copy link
Contributor

@finnian0826 finnian0826 commented Oct 17, 2024

Description

Show on EarnEnterAmount screen when withdrawalIncludesClaim is true and withdrawing

Test plan

Unit test added

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

MuckT and others added 30 commits October 2, 2024 15:08
# Conflicts:
#	src/earn/EarnDepositBottomSheet.tsx
Co-authored-by: Finnian Jacobson-Schulte <140328381+finnian0826@users.noreply.github.com>
@finnian0826 finnian0826 marked this pull request as ready for review October 17, 2024 21:22
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (229f1c1) to head (caf52ca).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6168      +/-   ##
==========================================
- Coverage   88.86%   88.86%   -0.01%     
==========================================
  Files         728      728              
  Lines       30995    30997       +2     
  Branches     5690     5692       +2     
==========================================
+ Hits        27544    27545       +1     
- Misses       3255     3256       +1     
  Partials      196      196              
Files with missing lines Coverage Δ
src/earn/EarnEnterAmount.tsx 89.16% <100.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 229f1c1...caf52ca. Read the comment docs.

Base automatically changed from tomm/act-1386 to main October 18, 2024 07:53
@finnian0826 finnian0826 added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 6e03eb4 Oct 18, 2024
15 checks passed
@finnian0826 finnian0826 deleted the finnian0826/act-1411 branch October 18, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants