chore(TransactionFeedV2): Move redux-related side-effects from component-level useEffects to the slice #6173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6173 +/- ##
==========================================
- Coverage 88.86% 88.86% -0.01%
==========================================
Files 728 728
Lines 31004 30995 -9
Branches 5694 5690 -4
==========================================
- Hits 27553 27543 -10
+ Misses 3409 3256 -153
- Partials 42 196 +154
... and 66 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jeanregisser
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
This is indirectly tested via the component, right?
There was a problem hiding this comment.
@jeanregisser Yes, it passes existing test for duplication cleanup and the new test for pre-populating the first page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
12th PR for RET-1207. Moves redux-related side-effects from component-level useEffects to the slice.
Test plan
Fixed all the corresponding tests to satisfy the new logic
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: