Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(earn): break pool info screen into multiple files #6176

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

satish-ravi
Copy link
Contributor

Description

EarnPoolInfoScreen is too big and has too many internal components, this breaks them into multiple files. Also organized all pool info screen files in a sub folder, as the number of files under src/earn was also increasing

Test plan

CI, no visual changes

Related issues

  • N/A

Backwards compatibility

Yes

Network scalability

N/A

@satish-ravi satish-ravi force-pushed the satish/clean-earn-pool-info-screen branch from 5c8798b to a3b06f5 Compare October 18, 2024 21:49
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 99.21875% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.87%. Comparing base (6e03eb4) to head (a3b06f5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/earn/poolInfoScreen/Cards.tsx 99.08% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #6176    +/-   ##
========================================
  Coverage   88.86%   88.87%            
========================================
  Files         728      730     +2     
  Lines       30997    31024    +27     
  Branches     5689     5386   -303     
========================================
+ Hits        27546    27573    +27     
- Misses       3255     3409   +154     
+ Partials      196       42   -154     
Files with missing lines Coverage Δ
...c/earn/poolInfoScreen/BeforeDepositBottomSheet.tsx 100.00% <ø> (ø)
src/earn/poolInfoScreen/EarnPoolInfoScreen.tsx 93.52% <100.00%> (ø)
src/earn/poolInfoScreen/SafetyCard.tsx 100.00% <100.00%> (ø)
src/earn/poolInfoScreen/TokenIcons.tsx 100.00% <100.00%> (ø)
src/earn/poolInfoScreen/Cards.tsx 99.08% <99.08%> (ø)

... and 65 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e03eb4...a3b06f5. Read the comment docs.

Copy link
Contributor

@jh2oman jh2oman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional nit: I feel like the InfoBottomSheet would be a good candidate to move out into its own file. It probably should be its own generalized file in components, but one step at a time.

@satish-ravi
Copy link
Contributor Author

satish-ravi commented Oct 18, 2024

yeah I thought about it too, I guess it can be it's own component within earn for now, don't want to generalize too much until it's reused in multiple places and inevitably end up with a component with multiple flags, each just for one use case.

@satish-ravi satish-ravi added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 02df87a Oct 19, 2024
15 checks passed
@satish-ravi satish-ravi deleted the satish/clean-earn-pool-info-screen branch October 19, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants