Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: race condition that prevents recovery phrase from showing sometimes #6177

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

kathaypacific
Copy link
Collaborator

@kathaypacific kathaypacific commented Oct 21, 2024

Description

Applying the fix that we made in the shefi project.

Test plan

n/a

Related issues

n/a

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.87%. Comparing base (6917e4c) to head (6da4c48).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/keylessBackup/SignInWithEmail.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6177      +/-   ##
==========================================
- Coverage   88.87%   88.87%   -0.01%     
==========================================
  Files         730      730              
  Lines       31024    31029       +5     
  Branches     5386     5693     +307     
==========================================
+ Hits        27573    27576       +3     
+ Misses       3409     3257     -152     
- Partials       42      196     +154     
Files with missing lines Coverage Δ
src/keylessBackup/SignInWithEmail.tsx 98.13% <83.33%> (-0.89%) ⬇️

... and 66 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6917e4c...6da4c48. Read the comment docs.

Copy link
Contributor

@sviderock sviderock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kathaypacific kathaypacific added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 0f20649 Oct 21, 2024
17 checks passed
@kathaypacific kathaypacific deleted the kathy/shefi-fix-port branch October 21, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants