Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(colors): sync names with design system #6188

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Conversation

satish-ravi
Copy link
Contributor

@satish-ravi satish-ravi commented Oct 25, 2024

Description

Sync colors with design system. Changes include:

  • Rename primary to accent (called appGreen in design system, but using accent to be independent of actual color after talking to Kayla)
  • Add primary color and set to black and use it for Button
  • Marked colors no longer in design system as deprecated
  • Removed duplicate exports of colors enum

Will make follow ups to update some inconsistencies in using colors

Test plan

Manually ensured primary button looks the same and no other changes

Related issues

Backwards compatibility

Yes

Network scalability

N/A

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.88%. Comparing base (53d9187) to head (fad0794).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/components/CurrencyDisplay.tsx 0.00% 1 Missing ⚠️
src/components/Dialog.tsx 0.00% 0 Missing and 1 partial ⚠️
src/components/RecoveryPhraseInput.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6188      +/-   ##
==========================================
- Coverage   88.90%   88.88%   -0.02%     
==========================================
  Files         733      733              
  Lines       31166    31166              
  Branches     5431     5736     +305     
==========================================
- Hits        27707    27703       -4     
+ Misses       3414     3264     -150     
- Partials       45      199     +154     
Files with missing lines Coverage Δ
src/account/SupportContact.tsx 96.25% <ø> (ø)
src/app/AppLoading.tsx 92.59% <ø> (ø)
src/app/MultichainBeta.tsx 90.90% <100.00%> (ø)
src/backup/BackupQuiz.tsx 84.67% <100.00%> (ø)
src/components/AddAssetsBottomSheet.tsx 100.00% <100.00%> (ø)
src/components/Button.tsx 100.00% <100.00%> (ø)
src/components/CircleButton.tsx 100.00% <ø> (ø)
src/components/CodeInput.tsx 100.00% <100.00%> (ø)
src/components/CodeRow.tsx 97.50% <ø> (ø)
src/components/DataFieldWithCopy.tsx 100.00% <100.00%> (ø)
... and 93 more

... and 59 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53d9187...fad0794. Read the comment docs.

Copy link
Contributor

@jh2oman jh2oman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the addition of accent, even better than what was proposed in the ticket with leaving it as green!

@satish-ravi satish-ravi added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit ba17b55 Oct 28, 2024
15 checks passed
@satish-ravi satish-ravi deleted the satish/act-1432-1 branch October 28, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants