feat(earn): prepare transactions and use on confirmation screen #6192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/earn/EarnDepositBottomSheet.tsx
Co-authored-by: Finnian Jacobson-Schulte <140328381+finnian0826@users.noreply.github.com>
MuckT
commented
Nov 1, 2024
| @@ -93,16 +92,22 @@ export async function prepareDepositTransactions({ | |||
| } | |||
| } | |||
|
|
|||
| export async function prepareWithdrawAndClaimTransactions({ | |||
| pool, | |||
| export async function prepareWithdrawTransactionsWithSwap({ | |||
There was a problem hiding this comment.
@satish-ravi Tried a few ways to make this work without having this additional function but came up short.
There was a problem hiding this comment.
you can still avoid duplicating the fn by calling prepareWithdrawTransactions from this function and adjusting the response type right? Similar to how we did in our pairing session except we did it with an inline function in the hook instead of an exported function with explicit args
There was a problem hiding this comment.
Was able to make this change in 8cffb5b and it is a lot cleaner. I tried to do something similar with prepareWithdrawAndClaimTransactions, but ran into issues merging the prepareTransactionsResult objects.
jh2oman
reviewed
Nov 6, 2024
jh2oman
reviewed
Nov 7, 2024
jh2oman
approved these changes
Nov 7, 2024
jophish
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handles the preparation of all earn transactions via a shared hook that's used on both
EarnEnterAmount.tsx&EarnConfirmationScreen.tsx.Test plan
Related issues
Backwards compatibility
Yes
Network scalability
N/A