Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fiatExchanges): support url params on external quotes #6195

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

jh2oman
Copy link
Contributor

@jh2oman jh2oman commented Oct 28, 2024

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (65b4db4) to head (b3ca4fe).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6195      +/-   ##
==========================================
- Coverage   88.89%   88.88%   -0.02%     
==========================================
  Files         733      733              
  Lines       31144    31168      +24     
  Branches     5719     5737      +18     
==========================================
+ Hits        27686    27704      +18     
- Misses       3261     3265       +4     
- Partials      197      199       +2     
Files with missing lines Coverage Δ
src/fiatExchanges/quotes/ExternalQuote.ts 92.59% <100.00%> (+0.09%) ⬆️
src/fiatExchanges/utils.tsx 78.57% <ø> (ø)

... and 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b4db4...b3ca4fe. Read the comment docs.

@jh2oman jh2oman enabled auto-merge October 28, 2024 21:45
@jh2oman jh2oman added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 811e881 Oct 28, 2024
15 checks passed
@jh2oman jh2oman deleted the quote-url branch October 28, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants