feat(earn): handle claims in withdraw submit saga #6203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/earn/EarnDepositBottomSheet.tsx
Co-authored-by: Finnian Jacobson-Schulte <140328381+finnian0826@users.noreply.github.com>
jh2oman
reviewed
Nov 6, 2024
src/earn/saga.ts
Outdated
| @@ -456,7 +463,132 @@ export function* withdrawSubmitSaga(action: PayloadAction<WithdrawInfo>) { | |||
| } | |||
| } | |||
|
|
|||
| export function* claimSubmitSaga(action: PayloadAction<WithdrawInfo>) { | |||
There was a problem hiding this comment.
I disagree with the choice to make this its own function. The vast majority of it is copy/paste and doing the exact steps as withdrawSubmitSaga. I don't think there is a strong motivation to separate them for separation of concerns, because their concerns are very close. Code-wise it looks like you will need to add two if statements max to withdrawSubmitSaga to be able to make it optionally include withdraw transactions or not.
am i missing something here?
MuckT
changed the title
jh2oman
reviewed
Nov 7, 2024
jh2oman
approved these changes
Nov 7, 2024
jophish
approved these changes
Nov 7, 2024
Co-authored-by: Joe Bergeron <jbergero@alum.mit.edu>
# Conflicts: # src/earn/EarnConfirmationScreen.test.tsx # src/earn/EarnConfirmationScreen.tsx # src/earn/hooks.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds claim handling to the
withdrawSubmitSagainsrc/earn/saga.tsto handle pending claim transactions. This PR also includes a fix where withdrawals that include claims do not prepare or include a separate claim transaction.Test plan
Related issues
Backwards compatibility
Yes
Network scalability
N/A