fix(feedV2): inverted swap from/to for deposits with swap #6204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakoushin
approved these changes
Oct 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6204 +/- ##
==========================================
- Coverage 88.93% 88.93% -0.01%
==========================================
Files 737 737
Lines 31368 31369 +1
Branches 5497 5494 -3
==========================================
Hits 27898 27898
- Misses 3425 3426 +1
Partials 45 45
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jophish
pushed a commit
to mobilestack-xyz/mobilestack-runtime
that referenced
this pull request
Nov 12, 2024
…#6204) ### Description Oops, I inverted from/to in valora-inc#6189 ### Test plan - Manually checked from/to are now as expected for swap and deposit. ### Related issues Part of RET-1204 ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Oops, I inverted from/to in #6189
Test plan
Related issues
Part of RET-1204
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: