Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup DefaultAvatar #6211

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Conversation

satish-ravi
Copy link
Contributor

Description

Replace DefaultAvatar directly with User icon to avoid nested svgs with viewbox.

Test plan

No visual changes in the tx feed

Related issues

N/A

Backwards compatibility

Yes

Network scalability

N/A

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (87e9599) to head (82e78c2).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6211      +/-   ##
==========================================
- Coverage   88.93%   88.92%   -0.01%     
==========================================
  Files         737      736       -1     
  Lines       31379    31370       -9     
  Branches     5804     5496     -308     
==========================================
- Hits        27907    27897      -10     
- Misses       3274     3429     +155     
+ Partials      198       44     -154     
Files with missing lines Coverage Δ
src/components/ContactCircle.tsx 100.00% <100.00%> (ø)

... and 66 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e9599...82e78c2. Read the comment docs.

Copy link
Collaborator

@MuckT MuckT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally by navigating to a transaction to check the display of src/components/ContactCircle.tsx

@satish-ravi satish-ravi added this pull request to the merge queue Nov 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2024
@satish-ravi satish-ravi added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 424fe4b Nov 6, 2024
16 checks passed
@satish-ravi satish-ravi deleted the satish/cleanup-contact-circle branch November 6, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants