chore: more app updates for UK compliance #6221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6221 +/- ##
========================================
Coverage 88.97% 88.97%
========================================
Files 736 737 +1
Lines 31422 31449 +27
Branches 5819 5521 -298
========================================
+ Hits 27958 27983 +25
- Misses 3420 3422 +2
Partials 44 44
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
### Description This PR contains all the requested changes described in the task. Some features that were required to be hidden to UK users could be done through existing feature flags, but I opted to consolidate the UK changes under the `SHOW_UK_COMPLIANT_VARIANT` flag for readability. ### Test plan User with activity: https://github.com/user-attachments/assets/e294569d-1165-45d1-be25-b810014468a5 User with no activity: https://github.com/user-attachments/assets/d61054df-7445-4753-a804-7de065554e2c ### Related issues - Fixes RET-1239 ### Backwards compatibility Y ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [ ] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains all the requested changes described in the task. Some features that were required to be hidden to UK users could be done through existing feature flags, but I opted to consolidate the UK changes under the
SHOW_UK_COMPLIANT_VARIANTflag for readability.Test plan
User with activity:
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-11-12.at.11.36.42.mp4
User with no activity:
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-11-11.at.17.15.50.mp4
Related issues
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: