Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove whitespace at bottom of web-view after keyboard dismiss #6253

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented Nov 21, 2024

Description

After merging #6217, there is a residual whitespace after dismissing the keyboard in web views; this PR removes that whitespace.

Android Before Android After
Screen.Recording.2024-11-20.at.4.56.59.PM.mov
Screen.Recording.2024-11-20.at.4.56.27.PM.mov

Test plan

  • Tested locally on iOS
  • Tested locally on Android

Related issues

N/A

Backwards compatibility

Yes

Network scalability

N/A

@MuckT
Copy link
Collaborator Author

MuckT commented Nov 21, 2024

@jeanregisser is there a better way to handle this besides adding the KeyboardSpacer component in the web view?

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.91%. Comparing base (24ede4b) to head (0f27cdf).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6253      +/-   ##
==========================================
- Coverage   88.92%   88.91%   -0.01%     
==========================================
  Files         737      737              
  Lines       31432    31433       +1     
  Branches     5530     5834     +304     
==========================================
- Hits        27952    27950       -2     
+ Misses       3436     3284     -152     
- Partials       44      199     +155     
Files with missing lines Coverage Δ
src/webview/WebViewScreen.tsx 62.39% <100.00%> (+0.32%) ⬆️

... and 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24ede4b...0f27cdf. Read the comment docs.

---- 🚨 Try these New Features:

@MuckT MuckT added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 9ddea5a Nov 22, 2024
15 checks passed
@MuckT MuckT deleted the tomm/rn-web-view-fix branch November 22, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants