fix: phone verification ends at CYA screen always #6266
Conversation
| @@ -60,10 +60,6 @@ describe('VerificationStartScreen', () => { | |||
| }) | |||
| const { getByText, getByTestId, queryByTestId, queryByText } = renderComponent() | |||
|
|
|||
| await act(() => { | |||
There was a problem hiding this comment.
these changes are to fix the (unrelated) act warnings
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6266 +/- ##
==========================================
+ Coverage 88.95% 88.96% +0.01%
==========================================
Files 739 739
Lines 31644 31649 +5
Branches 5892 5895 +3
==========================================
+ Hits 28149 28158 +9
+ Misses 3450 3446 -4
Partials 45 45
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| verificationCompletionScreen: !route.params?.hasOnboarded | ||
| ? Screens.OnboardingSuccessScreen |
There was a problem hiding this comment.
why do we need this special case? maybe we can add a short comment
📸 Snapshot TestBase build not foundNo build was found for the base commit 1ea0927. This is required to generate a snapshot diff for your pull request. It's possible that you created a branch off the base commit before all of the CI steps have finished processing, e.g. the one that uploads a build to our system. If that's the case, no problem! Just wait and this will eventually resolve. 🛸 Powered by Emerge Tools |
Description
The phone verification flow is hard coded to finish at the onboarding screens, which is unexpected because it can only be launched from the settings flow. This was raised at the release testing of the last release.
This PR makes the final screen in the flow configurable.
Test plan
https://linear.app/valora/issue/RET-641/[wallet]-user-not-seeing-updated-ota-translations#comment-15a73164
Related issues
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: