refactor(fiatExchanges): cleanup types #6293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satish-ravi
commented
Dec 4, 2024
Comment on lines
-21
to
-39
| export enum FiatExchangeFlow { | ||
| CashIn = 'CashIn', | ||
| CashOut = 'CashOut', | ||
| Spend = 'Spend', | ||
| } | ||
|
|
||
| export enum CICOFlow { | ||
| CashIn = 'CashIn', | ||
| CashOut = 'CashOut', | ||
| } | ||
|
|
||
| export enum PaymentMethod { | ||
| Bank = 'Bank', | ||
| Card = 'Card', | ||
| Coinbase = 'Coinbase', | ||
| MobileMoney = 'MobileMoney', // legacy mobile money | ||
| FiatConnectMobileMoney = 'FiatConnectMobileMoney', | ||
| Airtime = 'Airtime', | ||
| } |
There was a problem hiding this comment.
moved to ./types
| url: string | ||
| } | ||
|
|
||
| export type SimplexQuote = { |
There was a problem hiding this comment.
moved to ./types
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6293 +/- ##
==========================================
- Coverage 89.02% 89.01% -0.01%
==========================================
Files 739 739
Lines 31610 31607 -3
Branches 5571 5879 +308
==========================================
- Hits 28140 28135 -5
- Misses 3425 3427 +2
Partials 45 45
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
MuckT
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved types from fiatExchanges/utils to fiatExchanges/types and removed unused types. Left some legacy types that will be removed soon in utils
Test plan
CI
Related issues
Backwards compatibility
Yes
Network scalability
N/A