Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update copy for deposit to unknown app #6298

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

kathaypacific
Copy link
Collaborator

Description

It may be unavoidable that some dapps that we do not know about create transactions that are parsed as deposits / withdraws etc. The "unknown dapp" message reads a little bit like an error (and was flagged as such at bugapalooza, context) so this PR updates the copy. Open for other suggestions too.

Test plan

n/a

Related issues

n/a

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.01%. Comparing base (06bf2ee) to head (7159e9d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #6298    +/-   ##
========================================
  Coverage   89.01%   89.01%            
========================================
  Files         739      739            
  Lines       31610    31610            
  Branches     5880     5571   -309     
========================================
  Hits        28137    28137            
  Misses       3428     3428            
  Partials       45       45            

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06bf2ee...7159e9d. Read the comment docs.

Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kathaypacific kathaypacific added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 35dcd31 Dec 4, 2024
15 checks passed
@kathaypacific kathaypacific deleted the kathy/dapp-text branch December 4, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants