refactor: clean unused networkConfig #6342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6342 +/- ##
==========================================
- Coverage 88.95% 88.94% -0.02%
==========================================
Files 737 737
Lines 31445 31423 -22
Branches 5833 5823 -10
==========================================
- Hits 27973 27950 -23
- Misses 3274 3275 +1
Partials 198 198
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
satish-ravi
commented
Dec 10, 2024
| export enum CiCoCurrency { | ||
| CELO = 'CELO', | ||
| cUSD = 'cUSD', | ||
| cEUR = 'cEUR', | ||
| cREAL = 'cREAL', | ||
| ETH = 'ETH', |
There was a problem hiding this comment.
to make knip happy. This wasn't used anywhere. We should ultimately get rid of this, but there are some legacy fiat exchanges dependencies on this
satish-ravi
commented
Dec 10, 2024
There was a problem hiding this comment.
just removed RECAPTCHA_SITE_KEY here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed unused config, replaced config that could be easily inferred from another config.
Test plan
CI
Related issues
N/A
Backwards compatibility
N/A
Network scalability
N/A