chore: fix some typos #6348
Open
chore: fix some typos #6348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crazeteam <lilujing@outlook.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6348 +/- ##
==========================================
- Coverage 88.93% 88.92% -0.01%
==========================================
Files 737 737
Lines 31445 31445
Branches 5522 5829 +307
==========================================
- Hits 27965 27964 -1
+ Misses 3435 3283 -152
- Partials 45 198 +153
... and 65 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
MuckT
reviewed
Dec 12, 2024
| @@ -323,8 +323,8 @@ export default function FiatConnectReviewScreen({ route, navigation }: Props) { | |||
| serializablePreparedTransaction: | |||
| prepareTransactionsResult.result?.type === 'possible' | |||
| ? getSerializablePreparedTransaction( | |||
| prepareTransactionsResult.result.transactions[0] // there should be only one transaction | |||
There was a problem hiding this comment.
@crazeteam, you have a lint error here; mind running yarn lint in the repository's root and committing the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix some typos
Test plan
Related issues
Backwards compatibility
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: