-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add tests for mech interact states/base and models #191
Open
annasambrook
wants to merge
35
commits into
main
Choose a base branch
from
test/mech_interact_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ce5259
to
9b80937
Compare
# Conflicts: # docs/index.md # packages/packages.json # packages/valory/agents/impact_evaluator/aea-config.yaml # packages/valory/services/impact_evaluator/service.yaml # packages/valory/services/impact_evaluator_local/service.yaml # packages/valory/skills/impact_evaluator_abci/skill.yaml
feat: add mech-marketplace support
…est/mech_interact_tests # Conflicts: # docs/index.md # packages/packages.json # packages/valory/agents/impact_evaluator/aea-config.yaml # packages/valory/services/impact_evaluator/service.yaml # packages/valory/services/impact_evaluator_local/service.yaml # packages/valory/skills/impact_evaluator_abci/skill.yaml # packages/valory/skills/twitter_scoring_abci/skill.yaml
dvilelaf
reviewed
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some merge issues here, as several non-test files have changed (i.e mech_interact_abci)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
adding tests for mech interact
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
x
in the box that appliesChecklist
Put an
x
in the boxes that apply.main
branch (left side). Also you should start your branch off ourmain
.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...