Feat/acn #237
Merged
Feat/acn #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/index.md # packages/packages.json # packages/valory/agents/impact_evaluator/aea-config.yaml # packages/valory/services/impact_evaluator/service.yaml # packages/valory/services/impact_evaluator_local/service.yaml # packages/valory/skills/dynamic_nft_abci/skill.yaml # packages/valory/skills/generic_scoring_abci/skill.yaml # packages/valory/skills/impact_evaluator_abci/skill.yaml # packages/valory/skills/olas_week_abci/skill.yaml # packages/valory/skills/twitter_scoring_abci/skill.yaml
0xArdi
commented
Nov 21, 2024
Comment on lines
154
to
158
|
|
||
| def _check_required_attributes(self) -> None: | ||
| """Check that required attributes are set.""" | ||
| # skip the checks for this round | ||
| ... |
There was a problem hiding this comment.
likely related to a breaking change
dvilelaf
reviewed
Nov 22, 2024
| @@ -497,7 +497,6 @@ def async_act(self) -> Generator: | |||
| self.tx_hex, | |||
| self.price, | |||
| self.params.mech_chain_id, | |||
| self.synchronized_data.safe_contract_address, | |||
There was a problem hiding this comment.
This will break the service (contribute uses multiple safes on different chains and therefore needs to update the one in synced_data before each transaction). Why has it been removed?
# Conflicts: # docs/index.md # packages/packages.json # packages/valory/agents/impact_evaluator/aea-config.yaml # packages/valory/services/impact_evaluator/service.yaml # packages/valory/services/impact_evaluator_local/service.yaml # packages/valory/skills/impact_evaluator_abci/skill.yaml
dvilelaf
reviewed
Nov 29, 2024
| @@ -73,6 +73,7 @@ class StreamReadRound(CollectSameUntilThresholdRound): | |||
|
|
|||
| payload_class = StreamReadPayload | |||
| synchronized_data_class = SynchronizedData | |||
| required_class_attributes = () | |||
There was a problem hiding this comment.
What is this? Some new requireme from newer versions of Open Autonomy?
dvilelaf
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds support for ACN delivers on
mech_interact_abci.Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
xin the box that appliesChecklist
Put an
xin the boxes that apply.mainbranch (left side). Also you should start your branch off ourmain.