Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mech request round #250

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Fix mech request round #250

merged 2 commits into from
Jan 14, 2025

Conversation

Adamantios
Copy link
Collaborator

Proposed changes

The SKIP_REQUEST event could never be triggered as the payload for the mech request round was not constructed correctly in order for the none_event to be returned by the CollectSameUntilThresholdRound parent class.

This PR fixes the behaviour so that the payload is constructed correctly.

Fixes

n/a

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes

Further comments

n/a

The `SKIP_REQUEST` event could never be triggered as the payload was not constructed correctly in order for the `none_event` to be returned by the `CollectSameUntilThresholdRound` parent class.
@Adamantios Adamantios merged commit 02a9cca into main Jan 14, 2025
19 checks passed
@Adamantios Adamantios deleted the fix/mech-request branch January 14, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants