Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: updating tests #34

Merged
merged 12 commits into from
Aug 25, 2024
Merged

test: updating tests #34

merged 12 commits into from
Aug 25, 2024

Conversation

kupermind
Copy link
Collaborator

  • Adding and updating tests.

@kupermind kupermind requested a review from 77ph August 20, 2024 16:52
}

minResponseTimeout = newMinResponceTimeout;
maxResponseTimeout = newMaxResponceTimeout;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: event

/// @param newMinResponceTimeout New min response timeout.
/// @param newMaxResponceTimeout New max response timeout.
function changeMinMaxResponseTimeout(uint256 newMinResponceTimeout, uint256 newMaxResponceTimeout) external {
// Check for zero values
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ownership?

refactor: karma contract extracted to a separate one
@DavidMinarsch DavidMinarsch merged commit fc95043 into marketplace Aug 25, 2024
2 checks passed
@DavidMinarsch DavidMinarsch deleted the tests branch August 25, 2024 19:00
@DavidMinarsch DavidMinarsch restored the tests branch August 25, 2024 19:00
@DavidMinarsch DavidMinarsch deleted the tests branch August 25, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants