chore: move token ownership to proxy #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidMinarsch
commented
Dec 29, 2024
| @@ -176,7 +176,7 @@ contract ContributeManager is ERC721TokenReceiver { | |||
| instances[0] = msg.sender; | |||
|
|
|||
| // Create a service owned by this contract | |||
| serviceId = IService(serviceManager).create(address(this), token, configHash, agentIds, | |||
| serviceId = IService(serviceManager).create(contributorsProxy, token, configHash, agentIds, | |||
There was a problem hiding this comment.
NO asset should ever be held in the periphery, that's the whole point of the design paradigm. You need to proxy everything via the core (which has a proxy design and can therefore be updated in case of need)
DavidMinarsch
commented
Dec 29, 2024
kupermind
reviewed
Jan 2, 2025
| @@ -448,7 +452,7 @@ contract ContributeManager is ERC721TokenReceiver { | |||
| IStaking(curStakingInstance).unstake(serviceId); | |||
|
|
|||
| // Approve service NFT for the staking instance | |||
| INFToken(serviceRegistry).approve(curStakingInstance, serviceId); | |||
There was a problem hiding this comment.
Instead of doing something this ugly, why not just merge CM into the Contributors? Being a stand-alone ownerless contract was the sole purpose of it. If not - why even bother with periphery?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.