feat: add deploy script and Dockerfile #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| networks: { | ||
| hardhat: { | ||
| allowUnlimitedContractSize: true, | ||
| accounts: [ | ||
| { | ||
| privateKey: '0x6cbed15c793ce57650b9877cf6fa156fbef513c4e6134f022a85b1ffdd59b2a1', |
There was a problem hiding this comment.
Is this needed? I think default hardhat keys are always the same...
There was a problem hiding this comment.
I wasn't sure about the addresses, and I didn't want to take any chances as building + pushing a fix would take 1hr. This setup we have in the elcollectoorr contracts as well.
0xArdi
commented
Sep 20, 2022
Comment on lines
+19
to
+20
| # in case the build fails because it cannot download the solidity compilers | ||
| # run these commands locally, and comment them out from here. Notice the path! |
There was a problem hiding this comment.
This has happened a couple of time already on my local while building the image, with the same error as here: NomicFoundation/hardhat#1280
I haven't encountered it while building without docker.
0xArdi
commented
Sep 20, 2022
Comment on lines
+164
to
+166
| const { gnosisSafeFactory, gnosisSafeL2, defaultCallbackHandler } = await deploySafeContractDeps(); | ||
| const configuredSafeAddress = await deploySafeContract(gnosisSafeL2, gnosisSafeFactory, defaultCallbackHandler); | ||
|
|
There was a problem hiding this comment.
Regardless if used or not, we deploy the contracts. In this way we ensure that the balancer contracts will always have the same address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.