-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test task "Project A" #20
base: fix/demo
Are you sure you want to change the base?
Conversation
…2 seconds according to task desc
…ribed in the task
@dvilelaf @angrybayblade @dagacha i can't assign you as a reviewer due to permissions in the repo, but you should get a notification from a mention anyway |
Marija suggested to also add @Adamantios to the thread |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Yauhen! Sorry for the late response. I think there has been some misunderstanding with the exercise. We do not expect you to use Open-Autonomy or any of our repos to implement it.
Feel free to just use pure Python to implement a very simple "agent" that satisfies the requirements. Take it as an academic exercise, no need for complexity, just a couple of classes and methods to implement something that exchanges messages.
hi @dvilelaf , i've been traveling so saw your message only now. yup, i can re-implement it without use of the framework, but in that case i wonder which protocol should i use for communication between the agents? (particularly i'm concerned that in case of using pure python and http protocol - re-implementing aiohttp would take some effort) |
Hey Yauhen, bear in mind that this is an academic service and we are not
looking for any fancy implementation or protocol. Just use queues, list, or
whatever suits you. No need to use a specific protocol or advanced
techniques. We are just evaluating that you know how to implement python.
If you want to use any library or whatever, also feel free to do it. I just
said pure python meaning that you dont need to do any complicate task.
…On Mon, Aug 12, 2024 at 7:49 PM Actionless Loveless < ***@***.***> wrote:
hi @dvilelaf <https://github.com/dvilelaf> , i've been traveling so saw
your message only now.
yup, i can re-implement it without use of the framework, but in that case
i wonder which protocol should i use for communication between the agents&
(particularly i'm concerned that in case of using pure python and http
protocol - re-implementing aiohttp would take some effort)
—
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOI7JSXWGHSVYXSNXB2EHTZRDYSDAVCNFSM6AAAAABMBTJPQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBUGU4TGNZYHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
so, you mean that i could use agents as just python functions running inside the same eventloop? |
You’re free to come up with your own implementation. The only requirements
are the ones described on the exercise. As far as those are met, you can do
whatever you want.
El El mar, 13 ago 2024 a las 11:34, Actionless Loveless <
***@***.***> escribió:
… so, you mean that i could use agents as just python functions running
inside the same eventloop?
—
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOI7JQG4RKZKFZ2ONPUJOLZRHHLJAVCNFSM6AAAAABMBTJPQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBVHAYDKNJSGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
aight, then i'll implement it as mentioned above (as functions executed inside the same python process), but i'll leave interface easily extendable for implementing further features, like changing communication protocol i'll make it as a PR to new empty repo on my account talk to you tomorrow! |
i've created the PR there: actionless/valory-project-a-rev2#1 |
i've implemented Behavior and Handler themselves but i didn't figured out how exactly i should edit the config files to run 2 of them and communicate - so i was not able to test it neither manually or write an integration test.
i guess you could clarify my aforementioned problem as part of the review of this PR 😺