Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ofv support agent #251

Merged
merged 9 commits into from
Oct 3, 2024
Merged

Feat/ofv support agent #251

merged 9 commits into from
Oct 3, 2024

Conversation

0xArdi
Copy link
Collaborator

@0xArdi 0xArdi commented Sep 19, 2024

This PR adds the required changes for making the mech work the OFV tool.

Comment on lines +16 to +19
RUN pip uninstall opencv-python-headless || echo "opencv-python-headless not installed"

# re-install headless opencv
RUN pip install opencv-python-headless==4.10.0.84
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the underlying dependencies installs opencv-python. Even after uninstalling opencv-python, opencv-python-headless for some reason remains and causes issues when running in a docker container.

@0xArdi 0xArdi merged commit 56028df into main Oct 3, 2024
@0xArdi 0xArdi deleted the feat/ofv-support-agent branch October 3, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants