Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated _get_deliver_marketplace_tx function inside task_submission_a… #257

Merged

Conversation

KahanMajmudar
Copy link
Collaborator

@KahanMajmudar KahanMajmudar commented Oct 9, 2024

Proposed changes

Updates to make use of the new MechMarketplace Contract

  1. Updated behaviours.py of task_submission_abci to update the _get_deliver_marketplace_tx to use the new deliverToMarketplace smart contract method
  2. Updated AgentMech.json to account for the abi changes
  3. Added get_deliver_to_market_tx inside contract.py to interact with the deliverToMarketplace method

Fixes

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@0xArdi 0xArdi self-requested a review October 9, 2024 17:26
@0xArdi 0xArdi merged commit aec184f into valory-xyz:main Oct 14, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants