[WIP] ACN registration start up extension #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you send a message into the outbox, it will be automatically routed to the connection if you set |
DavidMinarsch
changed the base branch from
ACN-message-handler
to
ACN-service-registry-address
Karrenbelt
commented
Apr 15, 2022
Comment on lines
+198
to
+200
| # TODO: update tendermint config here | ||
| # use ABCI connection to send info to tendermint server | ||
| # - implement `update_validators` endpoint on server |
There was a problem hiding this comment.
Still need to implement handling of messages the agent receives, not sure where yet as I have not looked into it.
| self.context.logger.error(f"Failed processing tendermint response from {address}") | ||
|
|
||
| # when all information is collected, update and restart tendermint | ||
| if not self.registered_addresses.difference(self.collected): |
There was a problem hiding this comment.
Do guard clause instead, so return if condition not met to avoid nesting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
First draft on extending the registration skill with the request for Tendermint configuration sharing via the ACN.
Questions:
Also I realize refactoring and putting things in other places might be a good idea. I will not do that until it is fully functional, implementing it all in one place is easier. Primarily looking for feedback on the message flow at this stage.
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
xin the box that appliesChecklist
Put an
xin the boxes that apply.mainbranch (left side). Also you should start your branch off ourmain.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...