Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guard against deleted parent and child #42

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

raineorshine
Copy link
Contributor

@raineorshine raineorshine commented Dec 1, 2023

Close #41

Adds a guard to getNestedValues to prevent undefined error when child has already been deleted.

Added tests to 07_nested_map_spec.ts.

@raineorshine raineorshine changed the title fix: guard against undefined nested parent (#41) fix: guard against deleted child (#41) Dec 1, 2023
@raineorshine raineorshine changed the title fix: guard against deleted child (#41) fix: guard against deleted parent and child (#41) Dec 1, 2023
@raineorshine raineorshine force-pushed the delete-child-and-parent branch from 92da413 to a5496aa Compare December 1, 2023 18:14
@dai-shi dai-shi merged commit eed5e93 into valtiojs:main Dec 2, 2023
1 check passed
@dai-shi dai-shi changed the title fix: guard against deleted parent and child (#41) fix: guard against deleted parent and child Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined when deleting child and then parent
2 participants