writeBodyFixedSize: Only do an early flush if the reader is an *os.Fi…

…le (#1674)

or an *io.LimitedReader of an *os.File (because that's also supported by
https://cs.opensource.google/go/go/+/refs/tags/go1.21.4:src/bufio/bufio.go;l=784)

I think that having to flush less often outweighs the overhead of the
extra check. The appended data is known to be large, but it might still
save us a syscall by allowing it to buffer more.

http.go

@@ -2104,10 +2104,19 @@ func limitedReaderSize(r io.Reader) int64 {
 
 func writeBodyFixedSize(w *bufio.Writer, r io.Reader, size int64) error {
  if size > maxSmallFileSize {
- // w buffer must be empty for triggering
- // sendfile path in bufio.Writer.ReadFrom.
- if err := w.Flush(); err != nil {
- return err
+ earlyFlush := false
+ switch r := r.(type) {
+ case *os.File:
+ earlyFlush = true
+ case *io.LimitedReader:
+ _, earlyFlush = r.R.(*os.File)
+ }
+ if earlyFlush {
+ // w buffer must be empty for triggering
+ // sendfile path in bufio.Writer.ReadFrom.
+ if err := w.Flush(); err != nil {
+ return err
+ }
  }
  }