Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate request error to RetryIfFunc #1744

Closed
TAYTS opened this issue Apr 1, 2024 · 1 comment · Fixed by #1818
Closed

Propagate request error to RetryIfFunc #1744

TAYTS opened this issue Apr 1, 2024 · 1 comment · Fixed by #1818
Labels
help wanted

Comments

@TAYTS
Copy link

TAYTS commented Apr 1, 2024

Hi may I check is it possible to change the interface for the RetryIfFunc to pass the error for better retry strategy?
@erikdubbelboer
Copy link
Collaborator

There is no way to do this without breaking backwards compatibility. Maybe it would work if next to RetryIf we added a RetryIfErr. A pull request to try that out would be welcome.

@ksw2000 ksw2000 mentioned this issue Aug 6, 2024
Merged
ksw2000 added a commit to ksw2000/fasthttp that referenced this issue Aug 25, 2024
@ksw2000
Add RetryIfErr for Client
4f3f222 
Fix valyala#1744
In PR 1818, we only add RetryIfErr for HostClient but not for Client.
@ksw2000 ksw2000 mentioned this issue Aug 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
2 participants
@erikdubbelboer @TAYTS