feature: add ConvertRequest func #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To easy method to convert ctx.RequestCtx to http.Request
erikdubbelboer
requested changes
May 14, 2021
savsgio
suggested changes
May 14, 2021
fasthttpadaptor/request.go
Outdated
| // ConvertRequest convert a fasthttp.Request to http.Request | ||
| // setURI is optionally because your use in client mode | ||
| func ConvertRequest(ctx *fasthttp.RequestCtx, setURI bool) (*http.Request, error) { | ||
| var r http.Request |
There was a problem hiding this comment.
Maybe, the http.Request could be part of the ConvertRequest() parameters to can use a sync.Pool if it's needed.
There was a problem hiding this comment.
Somethig like this:
func ConvertRequest(ctx *fasthttp.RequestCtx, setURI bool, req *http.Request) error
There was a problem hiding this comment.
I'm not sure I agree with this. http.Request contains unexported fields. It's not trivial to reuse an http.Request with sync.Pool and the standard library gives no guarantee that this might break in the future.
But I guess it's up to the user to make this work properly.
|
@savsgio @erikdubbelboer Thanks for review! Can you revise again? |
erikdubbelboer
approved these changes
May 16, 2021
|
LGTM! |
savsgio
approved these changes
May 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To easy method to convert ctx.RequestCtx to http.Request