Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add golangci-lint config file for flexibility #1649

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Nov 8, 2023

This PR adds .golangci.yml with configuration for golangci-lint. The config file allows better flexibility in configuration in comparison with command-line parameters. E.g., in future, we might add additional helpful linters, disable some linter rules only for tests, etc.

Also, in the PR updated the version of golangci-lint to the latest currently released.

@alexandear alexandear force-pushed the add-golangci-lint-config branch from ab49eb3 to 1630a90 Compare November 8, 2023 15:39
.golangci.yml Outdated Show resolved Hide resolved
@alexandear alexandear force-pushed the add-golangci-lint-config branch from 1630a90 to 4c49dfa Compare November 9, 2023 10:29
@alexandear alexandear force-pushed the add-golangci-lint-config branch from 4c49dfa to e94085a Compare November 9, 2023 10:30
@erikdubbelboer erikdubbelboer merged commit 1242d8a into valyala:master Nov 9, 2023
11 of 14 checks passed
@erikdubbelboer
Copy link
Collaborator

Thanks!

@alexandear alexandear deleted the add-golangci-lint-config branch November 9, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants