Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dupword, unconvert linters #1658

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Nov 11, 2023

❯ golangci-lint run
bytesconv_test.go:40:18: unnecessary conversion (unconvert)
        expect := string(html.EscapeString(string(allcases)))
                        ^
fs.go:873:28: unnecessary conversion (unconvert)
        ff, ok := fileCache[string(path)]
                                  ^
fs.go:1597:16: unnecessary conversion (unconvert)
        r := io.Reader(f)
                      ^
client.go:1479:3: Duplicate words (d2) found (dupword)
                //  0(not set)            d2            d2
                ^
client.go:1481:3: Duplicate words (d2) found (dupword)
                //  0(not set)            d2            d2
                ^
http_test.go:3025:9: Duplicate words (size) found (dupword)
                t.Run("limit response body size size", func(t *testing.T) {
                      ^

@erikdubbelboer erikdubbelboer merged commit 8ecfc98 into valyala:master Nov 12, 2023
13 of 14 checks passed
@erikdubbelboer
Copy link
Collaborator

Thanks!

@alexandear alexandear deleted the enable-dupword-unconvert branch November 15, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants