client: deprecate misspelled 'MaxIdemponentCallAttempts' #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandear
force-pushed
the
client-deprecate-misspelled-const-fields
branch
from
0fa01bd
to
a823c23
Compare
alexandear
force-pushed
the
client-deprecate-misspelled-const-fields
branch
from
a823c23
to
081fb31
Compare
|
Thanks for the contribution but I don't think we should merge this. The API surface of fasthttp is already much too big. We wouldn't just be able to remove the old ones without breaking backwards compatibility. I guess we'll just have to live with some minor misspellings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates misspelled client's constant
DefaultMaxIdemponentCallAttemptsand fieldMaxIdemponentCallAttempts. The changes are backward-compatible. New tests are not needed because existing tests already cover usages of misspelled constant and field.