Merge the various proxy dialer implementations from the fasthttpproxy into a single struct. #1829
Conversation
newacorn
force-pushed
the
fasthttpproxy_refactor
branch
2 times, most recently
from
27677ca
to
f5f48fb
Compare
You are correct;I agree with your point. I forgot about backward compatibility and deduplication. Next, I will try to rewrite the existing functions. |
newacorn
force-pushed
the
fasthttpproxy_refactor
branch
from
f5f48fb
to
3c1fff8
Compare
fasthttpproxy/example_test.go
Outdated
| DialDualStack: true, | ||
| } | ||
| // proxy information comes from environment | ||
| dialer, err := p.GetDialFunc(false) |
There was a problem hiding this comment.
Shouldn't this be true if you want the config to come from the env?
There was a problem hiding this comment.
My thinking was somewhat flawed; I should have combined the three examples together. Thank you.
fasthttpproxy/example_test.go
Outdated
| _ = resp | ||
| } | ||
|
|
||
| func ExampleDialer_GetDialFunc_three() { |
There was a problem hiding this comment.
What is the difference between this and the second example? Besides NoProxy: "example.com",
There was a problem hiding this comment.
My thinking was somewhat flawed; I should have combined the three examples together. Thank you.
Add a multifunctional `Dialer` struct and reimplement the function API Reimplement the existing function interfaces of the fasthttpproxy package through Dialer. Refactor Dialer.GetDialFunc to ensure that its performance is comparable to the original function interfaces when the proxy does not change with the request address.
newacorn
force-pushed
the
fasthttpproxy_refactor
branch
from
3c1fff8
to
582ac0a
Compare
|
Thanks! |
#1822
In this issue, I noticed that the existing implementation doesn't leverage fasthttp's dialer mechanism, so I created this pull request.
At the same time, provide more comprehensive support for proxy environment variables and allow configuration of the fasthttp dialer.
No tests were committed, and the logic is built on top of the existing fasthttpproxy foundation. I noticed that the original fasthttpproxy also didn't include any test code.
The proxy address is not universal, but I did some local debugging and didn't find any issues.