Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solves failing test on my machine. #3

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Conversation

pietgk
Copy link
Contributor

@pietgk pietgk commented Jul 4, 2020

Home-test.tsx failed because was not correctly transpiled in test context on my machine.
The App worked for ios and android but testing failed.

I Got an error on: Home-test.tsx: const {getByText} = render()

I moved App.tsx into the src branche to get a correct version for testing.
This to match my preference of having all my components inside the src directory.

Also make a small typescript change to App.tsx SCREEN.

@vanGalilea vanGalilea merged commit 487c15a into vanGalilea:master Jul 6, 2020
@vanGalilea
Copy link
Owner

Hi Piet!

Always fun to see a familiar face from the React community in the Netherlands!
Thank you very much for you contribution, I highly appreciate it 🙏 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants