Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG-FIX: added kwargs to plugins #122

Merged
merged 6 commits into from
Feb 7, 2023
Merged

BUG-FIX: added kwargs to plugins #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ce9bd0
BUG-FIX: kwargs were not passed to uniform_sampler and marginal_distr…
gsel9 Feb 1, 2023
d65f10c
bumped mypy version in pre-commit due to dependency issues
gsel9 Feb 3, 2023
93ca7c4
Revert "bumped mypy version in pre-commit due to dependency issues"
gsel9 Feb 3, 2023
9dd2f00
Merge branch 'vanderschaarlab:main' into main
gsel9 Feb 7, 2023
31f34e7
Fixed to black formatting
gsel9 Feb 7, 2023
b3ba375
removed input arg
gsel9 Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/synthcity/plugins/generic/plugin_marginal_distributions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ class MarginalDistributionPlugin(Plugin):
"""

def __init__(self, **kwargs: Any) -> None:
super().__init__(
sampling_strategy="marginal",
)
super().__init__(sampling_strategy="marginal", **kwargs)

@staticmethod
def name() -> str:
Expand Down
2 changes: 1 addition & 1 deletion src/synthcity/plugins/generic/plugin_uniform_sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class UniformSamplerPlugin(Plugin):
"""

def __init__(self, **kwargs: Any) -> None:
super().__init__(sampling_strategy="uniform")
super().__init__(sampling_strategy="uniform", **kwargs)

@staticmethod
def name() -> str:
Expand Down
4 changes: 1 addition & 3 deletions tests/plugins/time_series/test_ts_marginal_distributions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,7 @@ def test_plugin_generate_survival() -> None:
time_horizons=time_horizons,
)

test_plugin = plugin(
n_iter=10,
)
test_plugin = plugin()
test_plugin.fit(survival_data)

X_gen = test_plugin.generate(10)
Expand Down