Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial + documentation for own data #128

Merged
merged 6 commits into from
Feb 14, 2023
Merged

Conversation

VHolstein
Copy link
Contributor

@VHolstein VHolstein commented Feb 12, 2023

Description

Added a tutorial how to rearrange data for the TimeSeriesDataLoader and added some Documentation for constructor args

Affected Dependencies

None

How has this been tested?

  • Ran Ipython Notebook locally

Added a tutorial on how to import time series from two data frames into the TimeSeriesDataLoader
Added documentation for TimeSeriesDataLoader and TimeSeriesSurvivalDataLoader constructor args
@bcebere
Copy link
Contributor

bcebere commented Feb 13, 2023

@VHolstein thank you for the contribution.

Please fix the test errors, and I will merge the PR. Also, please rename the notebook with a more intuitive name, something like "tutorial_6_time_series_data_preparation" or so.

Many thanks!

@VHolstein
Copy link
Contributor Author

@bcebere changed the tutorial name and fixed the whitespace errors, should be working now

Copy link
Contributor

@bcebere bcebere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM!

@bcebere bcebere merged commit c6af657 into vanderschaarlab:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants