Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exception in survival analysis data loader #148

Merged

Conversation

ZhaozhiQIAN
Copy link
Collaborator

@ZhaozhiQIAN ZhaozhiQIAN commented Mar 10, 2023

Description

Add exception to solve #147 .

Affected Dependencies

NA

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@ZhaozhiQIAN ZhaozhiQIAN linked an issue Mar 10, 2023 that may be closed by this pull request
@ZhaozhiQIAN
Copy link
Collaborator Author

Hi @bcebere I have some problem understanding this error. Could you help please?

black....................................................................Failed
- hook id: black
- files were modified by this hook

reformatted tests/metrics/test_statistical.py

@bcebere
Copy link
Contributor

bcebere commented Mar 15, 2023

Hi @bcebere I have some problem understanding this error. Could you help please?

black....................................................................Failed
- hook id: black
- files were modified by this hook

reformatted tests/metrics/test_statistical.py

Hello @ZhaozhiQIAN

Install pre-commit locally

pre-commit install

and run for all the files

pre-commit run --all

And commit the changes. It should be fine after that. In the future, it will run automatically on the files you change in a PR.

@robsdavis robsdavis merged commit 424b414 into main Mar 30, 2023
@robsdavis robsdavis deleted the 147-survival-analysis-dataloader-silently-removes-data-rows branch March 30, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Survival analysis DataLoader silently removes data rows
3 participants