Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

189 test failing in tutorials #190

Merged
merged 7 commits into from
May 5, 2023
Merged

Conversation

robsdavis
Copy link
Contributor

@robsdavis robsdavis commented May 4, 2023

Description

  • The timegan tutorial test was failing due to the lack of static data in the googlestocks data. This fix adds in the ability to handle this case. closes Test failing in tutorials #189
  • Fixes bug introduced by numpy>=1.24 that caused a few time series tests to fail, due to no longer handling jagged arrays.
  • Fixed bug that stopped ddpm model being run on gpu

Affected Dependencies

Additionally this fix adds lifelines!=0.27.5 to requirements, due to a bug in the lifelines release.

How has this been tested?

  • standard automated tests

Checklist

@robsdavis robsdavis linked an issue May 4, 2023 that may be closed by this pull request
@robsdavis robsdavis changed the title [WIP] 189 test failing in tutorials 189 test failing in tutorials May 4, 2023
@robsdavis robsdavis requested a review from DrShushen May 4, 2023 20:16
@DrShushen DrShushen added the bug Something isn't working label May 5, 2023
@DrShushen
Copy link
Member

I think ideally you might want to run test_full.yml with these changes just to check everything passes. I see there's no way to manually trigger the workflow run though.

Could you add the following line to test_pr.yml, test_full.yml and test_tutorials.yml?
https://github.com/vanderschaarlab/temporai/blob/main/.github/workflows/test.yml#L10

This will allow to manually trigger any of the workflows whenever you need (and you can choose the branch to run the workflow on), like here (see "Run Workflow" button):
https://github.com/vanderschaarlab/temporai/actions/workflows/test_full.yml

It might not get enabled until you merge this PR into main.

@robsdavis
Copy link
Contributor Author

Great idea. I've added the workflow_dispatch, but as you suggested it is not currently enabled. Think I will need to merge this PR first.

@robsdavis robsdavis merged commit 0118e0e into main May 5, 2023
@robsdavis robsdavis deleted the 189-test-failing-in-tutorials branch May 5, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failing in tutorials
2 participants